Fix retries when response is nil #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a failure occurs before `Request.HTTPResponse` is set, the retry handler will panic when trying to read `Request.HTTPResponse.Body`. This adds guards to the retry handler.
|
Hello @ryanbrainard, thank you for the PR! These changes look good. I'll merge them in once the checks pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a failure occurs before
Request.HTTPResponseis set, the retry handler will panic when trying to readRequest.HTTPResponse.Body. This adds guards to the retry handler.Note, this was partially fixed in #622, but this handles the case where the
Request.HTTPResponseis completelynil(not just anilBody).cc: @ricardochimal @fabiokung