Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in NewSelectObjectContentEventStream doc #4251

Conversation

weyfonk
Copy link

@weyfonk weyfonk commented Jan 21, 2022

A missing closing parenthesis is added to fix the syntax of the example call
provided in function documentation.

A missing closing parenthesis is added to fix the syntax of the example
call provided in function documentation.
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create a PR for this issue, the documentation is code generated using the SDK's event stream template Adding the ) to that file will allow us to ensure this change will not be lost next time the SDK's API Clients are regenerated.

jasdel added a commit to jasdel/aws-sdk-go that referenced this pull request Feb 3, 2022
Fixes missing closing parentese in event stream docstring found in
aws#4251
jasdel added a commit to jasdel/aws-sdk-go that referenced this pull request Feb 3, 2022
Fixes missing closing parentheses in event stream docstring found in
aws#4251
@jasdel
Copy link
Contributor

jasdel commented Feb 3, 2022

Thanks for taking the time to create this PR @weyfonk. I've created #4270 that updates the SDK's code generation for these docstrings.

@jasdel jasdel closed this Feb 3, 2022
jasdel added a commit that referenced this pull request Feb 11, 2022
Fixes missing closing parentheses in event stream docstring found in
#4251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants