Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Kinesis Video SigningName #4164

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Fix: Kinesis Video SigningName #4164

merged 2 commits into from
Jan 4, 2022

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Nov 8, 2021 •
edited
Loading

  • Fixes the SigningName for kinesis video by backfilling the correct name into the service model.
  • Updates the client constructor to set the SigningName to the EndpointID if the resolvers returns a derived or empty SigningName, and no SigningName is present in the model.

Fixes: #3367

@skmcgrail skmcgrail requested a review from jasdel November 8, 2021 18:00
jasdel
jasdel approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be good to make sure integration smoke tests are run and pass successfully before merge.

@jasdel jasdel self-requested a review November 10, 2021 19:16
jasdel
jasdel suggested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than codgen need handling of EndpointID not being generated for protocol tests.

@skmcgrail skmcgrail requested a review from jasdel November 18, 2021 18:26
@skmcgrail skmcgrail merged commit de43cec into aws:main Jan 4, 2022
@skmcgrail skmcgrail deleted the kinesisVideoFix branch January 4, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kinesis Video Signaling Channels - SDK may not get the correct name with custom endpoint
2 participants
@skmcgrail @jasdel