aws/endpoints: STS regional flag Implementation #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
suggested changes
Aug 26, 2019
jasdel
approved these changes
Aug 27, 2019
skmcgrail
reviewed
Aug 28, 2019
skmcgrail
approved these changes
Aug 28, 2019
…y using AwsPartition resolver for testing
jasdel
suggested changes
Oct 8, 2019
jasdel
approved these changes
Oct 8, 2019
skmcgrail
approved these changes
Oct 9, 2019
jasdel
removed
the
pr/work-in-progress
jasdel
approved these changes
Oct 23, 2019
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Oct 23, 2019
=== ### Service Client Updates * `service/connect`: Updates service API, documentation, and paginators * `service/polly`: Updates service API * Amazon Polly adds new female voices: US Spanish - Lupe and Brazilian Portuguese - Camila; both voices are available in Standard and Neural engine. * `service/sts`: Updates service documentation * AWS Security Token Service (STS) now supports a regional configuration flag to make the client respect the region without the need for the endpoint parameter. ### SDK Enhancements * `aws/endpoints`: Adds support for STS Regional Flags ([#2779](#2779)) * Implements STS regional flag, with support for `legacy` and `regional` options. Defaults to `legacy`. Legacy, will force all regions specified in aws/endpoints/sts_legacy_regions.go to resolve to the STS global endpoint, sts.amazonaws.com. This is the SDK's current behavior. * When the flag's value is `regional` the SDK will resolve the endpoint based on the endpoints.json model. This allows STS to update their service's modeled endpoints to be regionalized for all regions. When `regional` turned on use `aws-global` as the region to use the global endpoint. * `AWS_STS_REGIONAL_ENDPOINTS=regional` for environment, or `sts_regional_endpoints=regional` in shared config file. * The regions the SDK defaults to the STS global endpoint in `legacy` mode are: * ap-northeast-1 * ap-south-1 * ap-southeast-1 * ap-southeast-2 * aws-global * ca-central-1 * eu-central-1 * eu-north-1 * eu-west-1 * eu-west-2 * eu-west-3 * sa-east-1 * us-east-1 * us-east-2 * us-west-1 * us-west-2
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Oct 23, 2019
Release v1.25.18 (2019-10-23) === ### Service Client Updates * `service/connect`: Updates service API, documentation, and paginators * `service/polly`: Updates service API * Amazon Polly adds new female voices: US Spanish - Lupe and Brazilian Portuguese - Camila; both voices are available in Standard and Neural engine. * `service/sts`: Updates service documentation * AWS Security Token Service (STS) now supports a regional configuration flag to make the client respect the region without the need for the endpoint parameter. ### SDK Enhancements * `aws/endpoints`: Adds support for STS Regional Flags ([#2779](#2779)) * Implements STS regional flag, with support for `legacy` and `regional` options. Defaults to `legacy`. Legacy, will force all regions specified in aws/endpoints/sts_legacy_regions.go to resolve to the STS global endpoint, sts.amazonaws.com. This is the SDK's current behavior. * When the flag's value is `regional` the SDK will resolve the endpoint based on the endpoints.json model. This allows STS to update their service's modeled endpoints to be regionalized for all regions. When `regional` turned on use `aws-global` as the region to use the global endpoint. * `AWS_STS_REGIONAL_ENDPOINTS=regional` for environment, or `sts_regional_endpoints=regional` in shared config file. * The regions the SDK defaults to the STS global endpoint in `legacy` mode are: * ap-northeast-1 * ap-south-1 * ap-southeast-1 * ap-southeast-2 * aws-global * ca-central-1 * eu-central-1 * eu-north-1 * eu-west-1 * eu-west-2 * eu-west-3 * sa-east-1 * us-east-1 * us-east-2 * us-west-1 * us-west-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
STSregional flag, with support forlegacyandregionaloptions.Adds test case for regional flags in v3model_test.go
Certain regions specified in
aws/endpoints/sts_legacy_regionshave legacy support forSTS. Resolver resolves the endpoint to the global STS endpoint when the flag is not set toregional(case-insensitive).By default the value for the regional flag is
legacy. The env config declaration for the flag, has precedence over shared config.