service/s3/s3manager: Add unit test for S3 Upload manager part retries #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
issue-2525/UploadPartError
branch
2 times, most recently
from
f25f0e2 to
2ea8450
Compare
|
Go 1.7 on darwin, is periodically failing with |
jasdel
force-pushed
the
issue-2525/UploadPartError
branch
from
2ea8450 to
f9ff6e1
Compare
jasdel
force-pushed
the
issue-2525/UploadPartError
branch
from
f9ff6e1 to
17817aa
Compare
Adds a new unit test to S3 Upload Manager to verify the SDK will correctly retry concurrent multipart uploads. Update SDK's retry logic to include retrying write: connection reset and broken pipe, but not read: connection reset.
jasdel
force-pushed
the
issue-2525/UploadPartError
branch
from
c2eb323 to
235e028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new unit test to S3 Upload Manager to verify the SDK will
correctly retry concurrent multipart uploads.
Related to #2525