s3/s3manager: Buffer parts with io.SectionReader when possible #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves memory consumption on io.ReaderAt streams (files, in memory buffers) by avoiding creation of individual byte buffers. Increasing concurrency threshold for seekable streams will no longer impact memory usage. Fixes #232
|
LGTM |
jasdel
added a commit
that referenced
this pull request
May 28, 2015
s3/s3manager: Buffer parts with io.SectionReader when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves memory consumption on io.ReaderAt streams (files, in memory
buffers) by avoiding creation of individual byte buffers.
Increasing concurrency threshold for seekable streams will no longer
impact memory usage.
Fixes #232