Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ini: fixing bug where ':' was not valid in the profile #2247

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

xibz
Copy link
Contributor

@xibz xibz commented Nov 1, 2018

Fixes #2246

@xibz xibz requested a review from jasdel November 1, 2018 20:42
@xibz xibz changed the title fixing bug where ':' was not valid in the profile internal/ini: fixing bug where ':' was not valid in the profile Nov 1, 2018
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good minor nit with tabbing

internal/ini/testdata/valid/arn_profile_expected Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants