Trailing space in the Endpoint config parameter crashes the client

[sergeyfd]

Hello,

Client crashes if Endpoint has a trailing space:

awsConfig.WithEndpoint("some.server.com:80 ")

008c3463483c2d584738
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x4a438e]

goroutine 1 [running]:
panic(0x88cd80, 0xc82000a1a0)
    /home/dubros/goroot/go/src/runtime/panic.go:464 +0x3e6
aws/vendor/github.com/aws/aws-sdk-go/service/s3.validateSSERequiresSSL(0xc820057c00)
    /home/dubros/goroot/eng/src/aws/vendor/github.com/aws/aws-sdk-go/service/s3/sse.go:15 +0x17e
aws/vendor/github.com/aws/aws-sdk-go/aws/request.(*HandlerList).Run(0xc820057d08, 0xc820057c00)
    /home/dubros/goroot/eng/src/aws/vendor/github.com/aws/aws-sdk-go/aws/request/handlers.go:136 +0xc3
aws/vendor/github.com/aws/aws-sdk-go/aws/request.(*Request).Build(0xc820057c00, 0x0, 0x0)
    /home/dubros/goroot/eng/src/aws/vendor/github.com/aws/aws-sdk-go/aws/request/request.go:189 +0x69
aws/vendor/github.com/aws/aws-sdk-go/aws/request.(*Request).Sign(0xc820057c00, 0x0, 0x0)
    /home/dubros/goroot/eng/src/aws/vendor/github.com/aws/aws-sdk-go/aws/request/request.go:210 +0x31
aws/vendor/github.com/aws/aws-sdk-go/aws/request.(*Request).Send(0xc820057c00, 0x0, 0x0)
    /home/dubros/goroot/eng/src/aws/vendor/github.com/aws/aws-sdk-go/aws/request/request.go:258 +0x703
aws/vendor/github.com/aws/aws-sdk-go/service/s3.(*S3).ListBuckets(0xc820026080, 0xbc7b18, 0x4d30e4, 0x0, 0x0)
    /home/dubros/goroot/eng/src/aws/vendor/github.com/aws/aws-sdk-go/service/s3/api.go:998 +0x4f
main.ListBuckets(0xc820026080)
    /home/dubros/goroot/eng/src/aws/aws_gs.go:30 +0x59
main.main()
    /home/dubros/goroot/eng/src/aws/aws_gs.go:72 +0x105
Error: process exited with code 2.

[xibz]

Hello @sergeyfd, thank you for bringing this to our attention and the detailed log. I'll go ahead and try to reproduce it.

[xibz]

@sergeyfd - A current workaround is to Trim the url for now. We are looking into a fix. Again, thank you for reaching out to us.

[xibz]

Hello @sergeyfd, I have a PR #690 that addresses this issue! Going to close this for now and once merged in, if there are any additional problems, then please reach out to us.