Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose SourceIdentity on stscreds.AssumeRoleProvider #4829

Closed
1 of 2 tasks
addisonj opened this issue May 8, 2023 · 1 comment · Fixed by #4830
Closed
1 of 2 tasks

Expose SourceIdentity on stscreds.AssumeRoleProvider #4829

addisonj opened this issue May 8, 2023 · 1 comment · Fixed by #4830
Assignees
@RanVaknin
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue

Comments

@addisonj
Copy link
Contributor

addisonj commented May 8, 2023

Describe the feature

The raw sts.AssumeRole command supports a field SourcceIdentity.

However, when using the stscreds credentials helper, the AssumeRoleProvider does not expose this parameter

Use Case

This field is required to allow the AssumeRole credentials provider to expose all the features of the underlying assumeRole API call.

SourceIdentity has known use cases as documented by AWS

Proposed Solution

Improve the AssumeRoleProvider structure to take a source identity and map that the function call

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

1.44.259

Environment details (Version of Go (go version)? OS name and version, etc.)

N/A
@addisonj addisonj added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 8, 2023
addisonj pushed a commit to addisonj/aws-sdk-go that referenced this issue May 9, 2023
Add support for SourceIdentity to stscreds.NewCredentials
64deb07 
This commit adds support for exposing SourceIdentity on the
`AssumeRoleProvider` class.

This is a very small commit and just passes through the params.

Fixes aws#4829
@addisonj addisonj mentioned this issue May 9, 2023
Merged
@RanVaknin RanVaknin self-assigned this May 9, 2023
@RanVaknin RanVaknin added needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels May 9, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RanVaknin RanVaknin

Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for SourceIdentity to stscreds.NewCredentials addisonj/aws-sdk-go
2 participants
@addisonj @RanVaknin