prevent unused time import in event streams

aws · Jul 19, 2023 · 37fd361 · 37fd361
1 parent e4acaad
commit 37fd361
Show file tree

Hide file tree

Showing 10 changed files with 21 additions and 0 deletions.
diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md
@@ -3,3 +3,5 @@
 ### SDK Enhancements
 
 ### SDK Bugs
+* `codegen`: Prevent unused imports from being generated for event streams.
+  * Potentially-unused `"time"` import was causing vet failures on generated code.
diff --git a/private/model/api/codegentest/service/restjsonservice/api.go b/private/model/api/codegentest/service/restjsonservice/api.go
diff --git a/private/model/api/codegentest/service/restxmlservice/api.go b/private/model/api/codegentest/service/restxmlservice/api.go
diff --git a/private/model/api/codegentest/service/rpcservice/api.go b/private/model/api/codegentest/service/rpcservice/api.go
diff --git a/private/model/api/eventstream_tmpl.go b/private/model/api/eventstream_tmpl.go
@@ -22,8 +22,14 @@ func renderEventStreamAPI(w io.Writer, op *Operation) error {
 	op.API.AddSDKImport("private/protocol/eventstream")
 	op.API.AddSDKImport("private/protocol/eventstream/eventstreamapi")
 
+	// usages of these imports are conditional - generate a compile-only
+	// reference to avoid potential unused imports:
+	//  - awserr is only used for input streams or json protocols
+	//  - time is only used for input streams or if an event payload has a
+	//    timestamp field
 	w.Write([]byte(`
 var _ awserr.Error
+var _ time.Time
 `))
 
 	return eventStreamAPITmpl.Execute(w, op)

diff --git a/service/kinesis/api.go b/service/kinesis/api.go
diff --git a/service/lambda/api.go b/service/lambda/api.go
diff --git a/service/lexruntimev2/api.go b/service/lexruntimev2/api.go
diff --git a/service/s3/api.go b/service/s3/api.go
diff --git a/service/transcribestreamingservice/api.go b/service/transcribestreamingservice/api.go