Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/ec2/imds: Move the ec2imds module #984

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Dec 16, 2020

Moves the ec2imds module from the root of the SDK to a nested module under the feature folder. This improvement brings the EC2 IMDS client inline with other higher level features such as s3/manager and dynamodb/attributevalue

Copy link
Contributor

@skotambkar skotambkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would want documentation update to be paired with this change.

feature/ec2/imds/api_client.go Show resolved Hide resolved
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this pull request Dec 16, 2020
Updates documentation for aws#984
that relocates ec2imds to feature/ec2/imds
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this pull request Dec 16, 2020
Updates documentation for aws#984
that relocates ec2imds to feature/ec2/imds
@jasdel jasdel merged commit 2ba5cce into master Dec 16, 2020
@jasdel jasdel deleted the jasdel/refactor/EC2IMDS branch December 16, 2020 22:10
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this pull request Dec 16, 2020
Updates documentation for aws#984
that relocates ec2imds to feature/ec2/imds
jasdel added a commit that referenced this pull request Dec 16, 2020
Updates documentation for #984
that relocates ec2imds to feature/ec2/imds
shogo82148 added a commit to shogo82148/cloudwatch-logs-agent-lite that referenced this pull request Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants