Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty response body deser in case of error response #801

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Oct 7, 2020

Fixes xml deser util to correctly handle empty response body in case of an error response.

Fixes ec2query and s3shared xml deser utils too.

Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the SDK's behavior if there is a modeled response with response document/payload bindings, but the HTTP response body is empty? This SDK should not have an error if this occurs.

@skotambkar
Copy link
Contributor Author

skotambkar commented Oct 7, 2020

The SDK should handle that correctly. I will add test cases for success response case with empty body.

@skotambkar skotambkar requested a review from jasdel October 7, 2020 19:39
@skotambkar skotambkar merged commit 459e964 into master Oct 8, 2020
@skotambkar skotambkar deleted the fix-empty-response-deser branch October 25, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants