Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Feat flex checksum #2808

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Feat flex checksum #2808

wants to merge 30 commits into from

Conversation

wty-Bryant
Copy link
Contributor

Add client cfg to opt-in/out checksum calculation/validation, change default algorithm to calculate checksum

@wty-Bryant wty-Bryant requested a review from a team as a code owner September 26, 2024 03:33
lucix-aws
lucix-aws reviewed Sep 26, 2024
View reviewed changes
service/internal/checksum/middleware_compute_input_checksum.go Outdated Show resolved Hide resolved
aws/checksum.go Show resolved Hide resolved
aws/checksum.go Outdated Show resolved Hide resolved
lucix-aws
lucix-aws reviewed Sep 26, 2024
View reviewed changes
aws/checksum.go Outdated Show resolved Hide resolved
Madrigal
Madrigal reviewed Sep 30, 2024
View reviewed changes
aws/checksum.go Outdated Show resolved Hide resolved
config/provider.go Show resolved Hide resolved
config/provider.go Show resolved Hide resolved
service/internal/checksum/middleware_add.go Show resolved Hide resolved
service/internal/checksum/middleware_compute_input_checksum.go Show resolved Hide resolved
service/internal/checksum/middleware_compute_input_checksum_test.go Show resolved Hide resolved
service/internal/checksum/middleware_compute_input_checksum_test.go Show resolved Hide resolved
service/internal/checksum/middleware_setup_context.go Show resolved Hide resolved
service/internal/checksum/middleware_setup_context.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_validate_output.go Show resolved Hide resolved
lucix-aws
lucix-aws reviewed Sep 30, 2024
View reviewed changes
.changelog/9ebe24c4791541e0840da49eab6f9d97.json Outdated Show resolved Hide resolved
.changelog/9ebe24c4791541e0840da49eab6f9d97.json Outdated Show resolved Hide resolved
aws/checksum.go Outdated Show resolved Hide resolved
aws/checksum.go Outdated Show resolved Hide resolved
aws/checksum.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_add.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_setup_context.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_setup_context.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_compute_input_checksum.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_add.go Show resolved Hide resolved
Madrigal
Madrigal reviewed Oct 2, 2024
View reviewed changes
config/load_options.go Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_add.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_compute_input_checksum_test.go Show resolved Hide resolved
service/internal/checksum/middleware_compute_input_checksum.go Outdated Show resolved Hide resolved
service/internal/checksum/middleware_compute_input_checksum_test.go Outdated Show resolved Hide resolved
Madrigal
Madrigal reviewed Oct 7, 2024
View reviewed changes
.changelog/9ebe24c4791541e0840da49eab6f9d97.json Show resolved Hide resolved
aws/config.go Outdated Show resolved Hide resolved
config/load_options.go Show resolved Hide resolved
service/internal/checksum/middleware_compute_input_checksum.go Outdated Show resolved Hide resolved
lucix-aws
lucix-aws reviewed Oct 7, 2024
View reviewed changes
aws/config.go Outdated Show resolved Hide resolved
lucix-aws
lucix-aws reviewed Oct 8, 2024
View reviewed changes
aws/checksum.go Outdated Show resolved Hide resolved
lucix-aws
lucix-aws reviewed Oct 8, 2024
View reviewed changes
aws/checksum.go Outdated Show resolved Hide resolved
Madrigal
Madrigal approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Madrigal Madrigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had discussed and approved offline, but might as well give an explicit approval

@lucix-aws lucix-aws changed the title Feat flex checksum [DO NOT MERGE] Feat flex checksum Oct 8, 2024
Madrigal
Madrigal reviewed Nov 25, 2024
View reviewed changes
feature/s3/manager/integ_upload_test.go Show resolved Hide resolved
service/internal/checksum/algorithms.go Show resolved Hide resolved
service/internal/integrationtest/s3/checksum_test.go Show resolved Hide resolved
config/load_options.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucix-aws lucix-aws lucix-aws approved these changes

@Madrigal Madrigal Madrigal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wty-Bryant @Madrigal @lucix-aws