Fix unreleased capacity after retryToken is requested #1424
Conversation
| if len(e.Results) != len(a.Results) { | ||
| t.Fatalf("expected len %d got %d", len(e.Results), len(a.Results)) | ||
| } | ||
| for i, eRes := range e.Results { |
There was a problem hiding this comment.
This is a side effect of altering the return value with adding a function into it. Can no longer be deepEqualed. If anyone has a nice idea on how to fix that, I'm open for suggestions.
Sadly, it's late and I can't think of anything better ATM. :)
There was a problem hiding this comment.
I can experiment with a mock retry provider in these cases.
There was a problem hiding this comment.
We should be able to change how these values are compared to use cmp.Diff. This is commonly used for other data types in the v2 SDK.
There was a problem hiding this comment.
Though I'm not sure how that works for functions.
There was a problem hiding this comment.
Thanks for clarifying that. Yes, you're correct cmp.Diff doens't work with functions, checking for not-nil is pretty much the only way to compare in this case.
|
Thanks for taking the time to create this PR @Skarlso. I've taken these changes and incorporated them in #1560. That PR takes the idea of these changes, but instead of using a member on Lets use #1560 to get this changed merged in, and released into the SDK. |
|
@jasdel Nice improvement. :) |
Closes #1413
For further details, please read the attached issue.
One issue I could still see possibly is that this is always overwritten and only called ONCE after a success. I'm not familiar with the code enough that after a success the Attempt and the retry is re-created completely? Because then this could be fine.