Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smithy Document Shape Support #1320

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Smithy Document Shape Support #1320

merged 2 commits into from
Jul 29, 2021

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Jun 28, 2021 •
edited
Loading

Adds support for Smithy Document Shape Types for JSON protocols.

Depends on: aws/smithy-go#310

@skmcgrail skmcgrail requested review from jasdel and skotambkar June 28, 2021 20:17
@skmcgrail skmcgrail mentioned this pull request Jun 28, 2021
Merged
@skmcgrail skmcgrail requested a review from mtdowling June 29, 2021 16:42
jasdel
jasdel reviewed Jun 30, 2021
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider the impact to downstream applications that might have behavior using utilities like gocmp that caused us to add cmpopts.IgnoreTypes(smithydocument.NoSerde{}) to many places.

feature/dynamodb/attributevalue/empty_collections_test.go Show resolved Hide resolved
@skmcgrail skmcgrail requested a review from jasdel July 13, 2021 21:22
jasdel
jasdel approved these changes Jul 16, 2021
View reviewed changes
modman.toml Outdated Show resolved Hide resolved
@skmcgrail
Copy link
Member Author

Rebased on main

jasdel pushed a commit to aws/smithy-go that referenced this pull request Jul 29, 2021
@skmcgrail
Add Smithy Document Shape Support (#310)
d3a155d 
Adds support for Smithy Document shapes and supporting types for protocols to implement support.

AWS Protocol Support: aws/aws-sdk-go-v2#1320
@jasdel jasdel merged commit 17a3908 into aws:main Jul 29, 2021
@skmcgrail skmcgrail deleted the documentTypes branch November 8, 2021 18:12
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
@skmcgrail @jrichardpfs
Add Smithy Document Shape Support (aws#1320)
d6a5651 
Adds support for Smithy Document Shape Types for JSON protocols.

Depends on: aws/smithy-go#310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordonPhillips JordonPhillips JordonPhillips approved these changes

@jasdel jasdel jasdel approved these changes

@skotambkar skotambkar Awaiting requested review from skotambkar

@mtdowling mtdowling Awaiting requested review from mtdowling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skmcgrail @jasdel @JordonPhillips