awsQueryError trait support #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the order of a handful of switch cases have changed in the regeneration, these are expected since this moved from a TreeSet on the ShapeId to a TreeMap where the stable sorting is on the key string now. |
skmcgrail
force-pushed
the
awsQueryErrorTrait
branch
from
36adef9 to
9a3a5e4
Compare
mtdowling
approved these changes
Jun 3, 2021
skotambkar
reviewed
Jun 3, 2021
Comment on lines
+161
to
+175
| Map<String, ShapeId> errors = new TreeMap<>(); | ||
|
|
||
| operation.getErrors().forEach(shapeId -> { | ||
| Shape errorShape = context.getModel().expectShape(shapeId); | ||
| String errorName = shapeId.getName(context.getService()); | ||
|
|
||
| Optional<AwsQueryErrorTrait> errorShapeTrait = errorShape.getTrait(AwsQueryErrorTrait.class); | ||
| if (errorShapeTrait.isPresent()) { | ||
| errors.put(errorShapeTrait.get().getCode(), shapeId); | ||
| } else { | ||
| errors.put(errorName, shapeId); | ||
| } | ||
| }); | ||
|
|
||
| return errors; |
There was a problem hiding this comment.
Should this map key, value pair be reversed?
I would have expected shapeId to be the key, while errorName or code is the value. Is errorName or errorCode guaranteed to be unique within all operation error shapes?
There was a problem hiding this comment.
Error name has to be unique cause it is the shapeId name by default. For query alias’s and whether those conflict that would be a question for smithy on whether they validate that constraint.
skotambkar
approved these changes
Jun 3, 2021
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
* Support awsQueryError trait * Regenerated Clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for awsQueryError trait.
Requires aws/smithy-go#304