Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIPS & DualStack Endpoint Resolver Support #1274

Merged
merged 7 commits into from
Nov 4, 2021
Merged

FIPS & DualStack Endpoint Resolver Support #1274

merged 7 commits into from
Nov 4, 2021

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented May 25, 2021 •
edited
Loading

Support has been added for an updated endpoints.json model which contains modeled endpoint data for service dual-stack and FIPS endpoints.

Additionally, this support removes the need for the dual-stack customization in place for S3 and S3 Control service clients, and simplifies FIPS logic.

Requires: aws/smithy-go#303

@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 2 times, most recently from 53216cf to 0d71cc2 Compare May 25, 2021 16:04
@skmcgrail skmcgrail marked this pull request as draft May 25, 2021 16:35
@jasdel
Copy link
Contributor

jasdel commented May 25, 2021

Pending updated models.

@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 8 times, most recently from 542b76d to be91066 Compare June 1, 2021 16:22
skotambkar
skotambkar reviewed Jun 1, 2021
View reviewed changes
internal/endpoints/endpoints.go Outdated Show resolved Hide resolved
internal/endpoints/endpoints_test.go Outdated Show resolved Hide resolved
internal/endpoints/endpoints.go Outdated Show resolved Hide resolved
config/load_options.go Outdated Show resolved Hide resolved
internal/configsources/assert/config_test.go Outdated Show resolved Hide resolved
service/s3/internal/customizations/process_arn_resource.go Outdated Show resolved Hide resolved
@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 5 times, most recently from 032aa97 to cf6301e Compare June 2, 2021 23:10
@skmcgrail skmcgrail requested a review from skotambkar June 2, 2021 23:20
@skmcgrail
Copy link
Member Author

Requires aws/smithy-go#303

@skmcgrail skmcgrail changed the title UseDualStack Endpoint Resolver Support DualStack Endpoint Resolver Support Jun 2, 2021
@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 3 times, most recently from 8ee59a1 to 401d6de Compare June 3, 2021 02:20
@skmcgrail
Copy link
Member Author

Changes that were included in the last force push:

  • UseDualStack option on EndpointResolverOptions has been renamed to DualStackEndpoint
  • Constants have been renamed to DualStackEndpointUnset, DualStackEndpointEnabled, DualStackEndpointDisabled.
  • The config module refers to the setting a UseDualStackEndpoint to match the shared configuration name and better match with the endpoint options configuration name.

@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 3 times, most recently from 481ee20 to 5527177 Compare June 24, 2021 03:51
jasdel
jasdel reviewed Oct 22, 2021
View reviewed changes
aws/endpoints.go Outdated Show resolved Hide resolved
...hy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/EndpointGenerator.java Outdated Show resolved Hide resolved
...hy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/EndpointGenerator.java Show resolved Hide resolved
...hy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/EndpointGenerator.java Show resolved Hide resolved
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/ResolveClientConfigFromSources.java Outdated Show resolved Hide resolved
config/shared_config_test.go Show resolved Hide resolved
internal/endpoints/v2/endpoints.go Outdated Show resolved Hide resolved
internal/endpoints/v2/endpoints_test.go Outdated Show resolved Hide resolved
service/s3/internal/customizations/update_endpoint_test.go Outdated Show resolved Hide resolved
service/s3control/internal/customizations/update_endpoint_test.go Outdated Show resolved Hide resolved
@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 2 times, most recently from dc96e6c to d4307f0 Compare October 28, 2021 00:39
@skmcgrail skmcgrail requested review from jasdel and removed request for skotambkar October 28, 2021 17:15
@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 7 times, most recently from 9966884 to 6cadd83 Compare October 28, 2021 20:09
@skmcgrail skmcgrail force-pushed the dualStackEndpoints branch 4 times, most recently from a1cf4d8 to 9fa0c70 Compare November 4, 2021 00:09
@skmcgrail skmcgrail merged commit c524699 into aws:main Nov 4, 2021
@skmcgrail skmcgrail deleted the dualStackEndpoints branch November 4, 2021 19:00
@tiedotguy tiedotguy mentioned this pull request Nov 17, 2021
Closed
3 tasks
@tiedotguy tiedotguy mentioned this pull request Dec 1, 2021
Closed
3 tasks
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
@skmcgrail @jrichardpfs
FIPS & DualStack Endpoint Resolver Support (aws#1274)
232d830 
* DualStack and FIPS Modelling Support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotambkar skotambkar skotambkar approved these changes

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skmcgrail @jasdel @skotambkar