Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamoDB examples #1249

Merged
merged 6 commits into from
Feb 22, 2022
Merged

Add dynamoDB examples #1249

merged 6 commits into from
Feb 22, 2022

Conversation

jrichard8
Copy link
Contributor

Add some example of use of dynamoDB with AWS SDK v2

@skotambkar
Copy link
Contributor

@Doug-AWS can you take a look at this and see if these should be added to our V2 examples repo?

jasdel
jasdel suggested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples look good, we'll want to update the dependencies to be SDK's latest versions, and update the examples to use the SDK's ddb attribute value (un)marshalers.

@jrichard8 jrichard8 force-pushed the add-dynamodb-examples branch from b4cb33b to 5af5fdb Compare February 15, 2022 13:18
@jrichard8
Copy link
Contributor Author

I think I made requested changes, waiting for review.

@jrichard8 jrichard8 closed this Feb 15, 2022
@jrichard8 jrichard8 reopened this Feb 15, 2022
@jrichard8 jrichard8 requested a review from jasdel February 16, 2022 09:27
@jrichard8
Copy link
Contributor Author

@jasdel can you take a look ?

jasdel
jasdel approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create these examples. I've kicked off the CI Actions, and the changes look good. When these pass we should be able to merge in these example modules.

@jrichard8 jrichard8 requested a review from jasdel February 21, 2022 19:03
@jasdel jasdel merged commit 5c0e116 into aws:main Feb 22, 2022
@jrichard8 jrichard8 deleted the add-dynamodb-examples branch January 31, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel Awaiting requested review from jasdel

Assignees

@Doug-AWS Doug-AWS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrichard8 @skotambkar @jasdel @Doug-AWS @jrichardpfs