fix broken jmespath waiters in cloudwatch and autoscaling (#2984)

aws · Jan 23, 2025 · 640d919 · 640d919
1 parent 613a6cf
commit 640d919
Show file tree

Hide file tree

Showing 12 changed files with 316 additions and 120 deletions.
diff --git a/.changelog/516798334aa149998c84c0f9f62d13bb.json b/.changelog/516798334aa149998c84c0f9f62d13bb.json
@@ -0,0 +1,9 @@
+{
+    "id": "51679833-4aa1-4999-8c84-c0f9f62d13bb",
+    "type": "bugfix",
+    "description": "Switch to generated waiters, removing the dependency on go-jmespath and fixing broken waiters that used ordering comparators.",
+    "modules": [
+        "service/autoscaling",
+        "service/cloudwatch"
+    ]
+}
diff --git a/SMITHY_GO_CODEGEN_VERSION b/SMITHY_GO_CODEGEN_VERSION
@@ -1 +1 @@
-a7d0f1ef5f730836889f670f8d739456fc940779
+d708d1d4ae7dc9bc80ae20d1e09623fba519e9d7
diff --git a/...odegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/AwsWaiters2.java b/...odegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/AwsWaiters2.java
@@ -12,7 +12,9 @@
 
 public class AwsWaiters2 extends Waiters2 {
     public static final List<ShapeId> PHASED_ROLLOUT_SERVICES = List.of(
-            ShapeId.from("com.amazonaws.ec2#AmazonEC2")
+            ShapeId.from("com.amazonaws.ec2#AmazonEC2"),
+            ShapeId.from("com.amazonaws.autoscaling#AutoScaling_2011_01_01"),
+            ShapeId.from("com.amazonaws.cloudwatch#GraniteServiceVersion20100801")
     );
 
     @Override

diff --git a/service/autoscaling/api_op_DescribeAutoScalingGroups.go b/service/autoscaling/api_op_DescribeAutoScalingGroups.go
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		a7d0f1ef5f730836889f670f8d739456fc940779
		d708d1d4ae7dc9bc80ae20d1e09623fba519e9d7