service/s3/s3manager: Fix return signature from conflicting changes (#…

…407)
aws · Oct 1, 2019 · 51d362f · 51d362f
1 parent 11a6d37
commit 51d362f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/service/s3/s3manager/upload.go b/service/s3/s3manager/upload.go
@@ -467,21 +467,21 @@ func (u *uploader) nextReader() (io.ReadSeeker, int, func(), error) {
 
 	default:
 		part := u.cfg.partPool.Get().([]byte)
+		cleanup := func() {
+			u.cfg.partPool.Put(part)
+		}
+
 		n, err := readFillBuf(r, part)
 		if n < 0 {
 			if err == nil {
 				err = fmt.Errorf(
 					"unable to read part, got negative bytes read(%d) without error, %v",
 					n, err)
 			}
-			return nil, n, err
+			return nil, n, cleanup, err
 		}
 		u.readerPos += int64(n)
 
-		cleanup := func() {
-			u.cfg.partPool.Put(part)
-		}
-
 		return bytes.NewReader(part[0:n]), n, cleanup, err
 	}
 }