fix: remove invalid escaping of shared config values (#2461)

aws · Jan 22, 2024 · 4c897d4 · 4c897d4
1 parent c07adfa
commit 4c897d4
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 13 deletions.
diff --git a/.changelog/3d35583634994f17915c859ae0c1f0f4.json b/.changelog/3d35583634994f17915c859ae0c1f0f4.json
@@ -0,0 +1,10 @@
+{
+    "id": "3d355836-3499-4f17-915c-859ae0c1f0f4",
+    "type": "bugfix",
+    "description": "Remove invalid escaping of shared config values. All values in the shared config file will now be interpreted literally, save for fully-quoted strings which are unwrapped for legacy reasons.",
+    "modules": [
+        ".",
+        "config",
+        "internal/ini"
+    ]
+}
diff --git a/internal/ini/strings.go b/internal/ini/strings.go
@@ -67,12 +67,8 @@ func unquote(s string) string {
 
 // applies various legacy conversions to property values:
 //   - remote wrapping single/doublequotes
-//   - expand escaped quote and newline sequences
 func legacyStrconv(s string) string {
 	s = unquote(s)
-	s = strings.ReplaceAll(s, `\"`, `"`)
-	s = strings.ReplaceAll(s, `\'`, `'`)
-	s = strings.ReplaceAll(s, `\n`, "\n")
 	return s
 }
 

diff --git a/internal/ini/testdata/valid/escaped_profile b/internal/ini/testdata/valid/escaped_profile
diff --git a/internal/ini/testdata/valid/escaped_profile_expected b/internal/ini/testdata/valid/escaped_profile_expected