feat: Add wait timeout for deploy command

[cullenwatson]

• closes How do I increase the time limit for sam deploy? #4478

[jysheng123]

Would you be able to make a unit test where the max_wait_duration is really low like 5 seconds and test that it goes through?

[cullenwatson]

Would you be able to make a unit test where the max_wait_duration is really low like 5 seconds and test that it goes through?

It is in minutes. Is there a way we could test one minute timeout?

[jysheng123]

Hmm, yeah on second thought, this seems fine to me to test since the previous hard coded value was 120 seconds anyways, maybe a NIT that im thinking of is the possibility of the sam deploy time outing for an in definite amount of time, so maybe something like setting a reasonable upper limit like 10 minutes to me.

[cullenwatson]

ok i just put min of 60 minutes and max 480 minutes as 480 was what the op wanted

[hawflau]

Hi @cullenwatson could you please check the failed checks and fix accordingly? Seems like there's some linting issues, and you also need to run make schema to update the SAM CLI command schema as you added a new command option

[lucashuy]

Hi @cullenwatson, just wanted to check in to see if you had any blockers or help wanted to continue contributing.

[cullenwatson]

ok the tests are passing now besides the 2 that are failing also in main

[iainelder]

@cullenwatson , thanks for this improvement!

I'm no longer working on the project that needed SAM to run longer than 1 hour, so I'm no longer in a position to test this.

I've passed on the good news anyway.