Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip file opened event for template watcher #7096

Merged
merged 9 commits into from
May 27, 2024

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented May 23, 2024

Which issue(s) does this change fix?

#7058

Why is this change necessary?

When watching the template.yaml file, file opened event gets triggered indefinitely for some cases on Linux systems, which causes high CPU usage.

How does it address the issue?

We already skipping file opened event for some other file watchers for the sam sync, this PR also applies same fix to the template listener as well.

What side effects does this change have?

Since file opened event is already skipped in other places, this shouldn't have any side affects for this usage as well.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci changed the title Add logs for file watchers fix: skip file opened event for template watcher May 23, 2024
@mndeveci mndeveci marked this pull request as ready for review May 23, 2024 16:07
@mndeveci mndeveci requested a review from a team as a code owner May 23, 2024 16:07
@mndeveci mndeveci requested review from lucashuy and mildaniel May 23, 2024 16:07
@mildaniel mildaniel added this pull request to the merge queue May 27, 2024
Merged via the queue into aws:develop with commit 3a337ec May 27, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants