Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in PR#6719 #6794

Merged
merged 21 commits into from
Mar 8, 2024
Merged

Fix bug in PR#6719 #6794

merged 21 commits into from
Mar 8, 2024

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Mar 8, 2024

Which issue(s) does this change fix?

Why is this change necessary?

A bug was introduced due to unexpected args in calling InvokeContext

How does it address the issue?

fix the bug

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Jared Bentvelsen and others added 18 commits February 20, 2024 11:11
@github-actions github-actions bot added area/local/invoke sam local invoke command pr/internal labels Mar 8, 2024
@hawflau hawflau marked this pull request as ready for review March 8, 2024 19:36
@hawflau hawflau requested a review from a team as a code owner March 8, 2024 19:36
@hawflau hawflau requested review from lucashuy and mildaniel March 8, 2024 19:36
@hawflau hawflau enabled auto-merge March 8, 2024 19:44
@hawflau hawflau added this pull request to the merge queue Mar 8, 2024
Merged via the queue into develop with commit 39240d0 Mar 8, 2024
55 checks passed
hawflau added a commit that referenced this pull request Mar 9, 2024
@hawflau
Revert "Fix bug in PR#6719 (#6794)"
8ba4efa 
This reverts commit 39240d0.
@hawflau hawflau mentioned this pull request Mar 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 9, 2024
@hawflau
Revert "Fix bug in PR#6719" (#6800)
d8c2b7a 
* Revert "Fix bug in PR#6719 (#6794)"

This reverts commit 39240d0.

* Revert "Handle Container Creation Failure in `local invoke`, `local start-api` and `local start-lambda` (#6719)"

This reverts commit 9bcbc04.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidhujus sidhujus sidhujus approved these changes

@hnnasit hnnasit hnnasit approved these changes

@lucashuy lucashuy Awaiting requested review from lucashuy lucashuy is a code owner automatically assigned from aws/serverless-application-experience-sbt

@mildaniel mildaniel Awaiting requested review from mildaniel mildaniel is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/local/invoke sam local invoke command pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawflau @hnnasit @sidhujus