Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: install dotnet8 in CI (appveyor) #6461

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Dec 16, 2023

Which issue(s) does this change fix?

Why is this change necessary?

To update CI for it to be ready for testing dotnet8 runtimes (#6429)
Windows is not needed because it already has dotnet8 (https://www.appveyor.com/docs/windows-images-software/#net-framework)

How does it address the issue?

Install dotnet8 sdk via apt-get

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau requested a review from a team as a code owner December 16, 2023 00:01
@hawflau hawflau added this pull request to the merge queue Jan 2, 2024
Merged via the queue into aws:develop with commit 2c3655b Jan 2, 2024
55 checks passed
@hawflau hawflau deleted the dotnet8-ci branch January 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants