Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #589: TypeError when generating Kinesis event. #590

Closed
wants to merge 2 commits into from
Closed

Issue #589: TypeError when generating Kinesis event. #590

wants to merge 2 commits into from

Conversation

phoenik
Copy link

@phoenik phoenik commented Jul 30, 2018

Issue #, if available:
#589

Description of changes:
Decoding bytes to str for json serialization when generating a kinesis event.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss
Copy link
Contributor

jfuss commented Aug 1, 2018

@phoenik Thank you for putting the time into addressing this. We are currently working on revamping the generate-event command. Given that work, we can't accept these changes at the moment.

@jfuss jfuss added the area/local/generate-event sam local generate-event command label Aug 1, 2018
@jfuss
Copy link
Contributor

jfuss commented Aug 10, 2018

Things should be covered by #612. Closing this in favor of larger one here.

@jfuss jfuss closed this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/local/generate-event sam local generate-event command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants