fix: supporting nested apis for v1 method, integration, and integration response resources. #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on response resources.
lucashuy
approved these changes
Aug 4, 2023
mildaniel
approved these changes
Aug 4, 2023
mildaniel
added a commit
that referenced
this pull request
Aug 5, 2023
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
mildaniel
added a commit
that referenced
this pull request
Aug 5, 2023
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
mildaniel
added a commit
that referenced
this pull request
Aug 5, 2023
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install * Fix install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
mildaniel
added a commit
that referenced
this pull request
Aug 5, 2023
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install * Fix install * Fix install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
mildaniel
added a commit
that referenced
this pull request
Aug 5, 2023
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install * Fix install * Fix install * Fix conflict --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
moelasmar
added a commit
that referenced
this pull request
Aug 6, 2023
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install * Fix install * Fix install * Fix conflict * Format files * feat: updating app templates repo hash with (590b5e90d681c504213e6c35d56c0d63d9401c0b) (#5668) Co-authored-by: GitHub Action <[email protected]> * use get_sam_command to get the base sam command in regression pacakge test cases. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Daniel Mil <[email protected]> Co-authored-by: Daniel Mil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
follow up on PR #5697 to fix issue #5639
Why is this change necessary?
Customers are not able to run SAM CLI commands on Terraform projects that contains nested V1 APIs definition
How does it address the issue?
It allowed the following resources to be linked to multiple destinations (Rest API, and Gateway Resource):
What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.