Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate sam init schema #5560

Merged
merged 11 commits into from
Jul 21, 2023
Merged

Conversation

Leo10Gama
Copy link
Member

With this change, the schema for sam init will be added to the JSON schema. It will serve to validate the parameters in samconfig for the init command.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Leo10Gama Leo10Gama requested a review from a team as a code owner July 18, 2023 22:53
@Leo10Gama Leo10Gama requested review from lucashuy and jfuss July 18, 2023 22:53
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jul 18, 2023
schema/samcli.json Outdated Show resolved Hide resolved
Leonardo Gama added 2 commits July 20, 2023 11:48
Also, add sorting to enums for consistency
schema/schema.py Fixed Show fixed Hide fixed
schema/schema.py Fixed Show fixed Hide fixed
schema/schema.py Outdated Show resolved Hide resolved
schema/schema.py Fixed Show fixed Hide fixed
schema/schema.py Fixed Show fixed Hide fixed
schema/schema.py Show resolved Hide resolved
@lucashuy lucashuy merged commit f39bd47 into aws:feat/json-schema Jul 21, 2023
@Leo10Gama Leo10Gama deleted the init-schema branch July 21, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/internal stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants