Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid response with new line symbol #541

Merged
merged 1 commit into from
Jul 11, 2018
Merged

fix: invalid response with new line symbol #541

merged 1 commit into from
Jul 11, 2018

Conversation

zsc347
Copy link
Contributor

@zsc347 zsc347 commented Jul 7, 2018 •
edited
Loading

Issue #531

Description of changes: fix corner case that only one '\n' in response

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zsc347 zsc347 force-pushed the develop branch 2 times, most recently from c4e7dd1 to e3fcd5f Compare July 7, 2018 11:58
sanathkr
sanathkr approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@sanathkr sanathkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Congrats on getting your first PR 🎉

@sanathkr sanathkr added the stage/accepted Accepted and will be fixed label Jul 10, 2018
@jfuss
Copy link
Contributor

jfuss commented Jul 11, 2018

@zsc347 Would you be able to fix the test? When I added the decode the last parameter in the param() needs to be a str not bytes.

@zsc347
Copy link
Contributor Author

zsc347 commented Jul 11, 2018

I'll fix it

@zsc347
Copy link
Contributor Author

zsc347 commented Jul 11, 2018

@jfuss Fix done. Could you pls check?

jfuss
jfuss approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. WOOTT! First PR :)

@jfuss jfuss merged commit c0973cd into aws:develop Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfuss jfuss jfuss approved these changes

@sanathkr sanathkr sanathkr approved these changes

Assignees
No one assigned
Labels
stage/accepted Accepted and will be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsc347 @jfuss @sanathkr