Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix failing tests on Python3.11 #5317

Merged
merged 2 commits into from
Jun 9, 2023
Merged

fix: Fix failing tests on Python3.11 #5317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd4be14
fix: Fix failing tests on Python3.11
mildaniel Jun 9, 2023
f654a1c
Merge branch 'develop' into fix-py311-tests
mildaniel Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration/local/invoke/runtimes/test_with_runtime_zips.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def setUp(self):
def tearDown(self):
os.remove(self.events_file_path)

@pytest.mark.timeout(timeout=300, method="thread")
@parameterized.expand([param("Go1xFunction"), param("Java8Function")])
@pytest.mark.timeout(timeout=300, method="thread")
def test_runtime_zip(self, function_name):
command_list = InvokeIntegBase.get_command_list(
function_name, template_path=self.template_path, event_path=self.events_file_path
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/sync/test_sync_infra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ def _verify_infra_changes(self, resources):
IS_WINDOWS,
"Skip sync ruby tests in windows",
)
@pytest.mark.flaky(reruns=3)
@parameterized.expand([["ruby", False], ["python", False], ["python", True]])
@pytest.mark.flaky(reruns=3)
def test_sync_infra(self, runtime, use_container):
template_before = f"infra/template-{runtime}-before.yaml"
template_path = str(self.test_data_path.joinpath(template_before))
Expand Down Expand Up @@ -147,8 +147,8 @@ def test_sync_infra(self, runtime, use_container):
else:
self._verify_infra_changes(self.stack_resources)

@pytest.mark.flaky(reruns=3)
@parameterized.expand([["python", False], ["python", True]])
@pytest.mark.flaky(reruns=3)
def test_sync_infra_auto_skip(self, runtime, use_container):
template_before = f"infra/template-{runtime}-before.yaml"
template_path = str(self.test_data_path.joinpath(template_before))
Expand Down Expand Up @@ -208,8 +208,8 @@ def test_sync_infra_auto_skip(self, runtime, use_container):
# Lambda Api call here, which tests both the python function and the layer
self._verify_infra_changes(self.stack_resources)

@pytest.mark.flaky(reruns=3)
@parameterized.expand([["python", False], ["python", True]])
@pytest.mark.flaky(reruns=3)
def test_sync_infra_auto_skip_nested(self, runtime, use_container):
template_before = str(Path("infra", "parent-stack.yaml"))
template_path = str(self.test_data_path.joinpath(template_before))
Expand Down