Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bug: CORS Support in start-api (#4991)" #5200

Merged
merged 2 commits into from
May 25, 2023
Merged

Revert "Bug: CORS Support in start-api (#4991)" #5200

merged 2 commits into from
May 25, 2023

Conversation

moelasmar
Copy link
Contributor

This reverts commit 3882c3d.

The PR causes some regression and failing some of our integration test cases:

FAILED tests/integration/local/start_api/test_start_api.py::TestServiceCorsSwaggerRequests::test_cors_swagger_options - AssertionError: None != '*'
FAILED tests/integration/local/start_api/test_start_api.py::TestServiceCorsSwaggerRequestsWithHttpApi::test_cors_swagger_options_httpapi - AssertionError: None != '*'
FAILED tests/integration/local/start_api/test_start_api.py::TestServiceCorsGlobalRequests::test_cors_global - AssertionError: None != '*'
FAILED tests/integration/local/start_api/test_start_api.py::TestCFNTemplateQuickCreatedHttpApiWithDefaultRoute::test_cors_options - AssertionError: None != 'https://example.com'
FAILED tests/integration/local/start_api/test_start_api_cdk_template.py::TestServiceCorsRequests::test_cors_swagger_options - AssertionError: None != '*'

I deployed this template and compared between the CORS Headers returned in the API Gateway response and it is deferent from SAM CLI response with this PR, but matching SAM CLI response without it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@moelasmar moelasmar requested a review from a team as a code owner May 25, 2023 19:41
@moelasmar moelasmar requested review from hawflau and jfuss May 25, 2023 19:41
@moelasmar moelasmar mentioned this pull request May 25, 2023
Merged
8 tasks
@moelasmar moelasmar added this pull request to the merge queue May 25, 2023
Merged via the queue into aws:develop with commit 2a7b1c8 May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucashuy lucashuy lucashuy approved these changes

@hawflau hawflau hawflau approved these changes

@jfuss jfuss Awaiting requested review from jfuss jfuss was automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moelasmar @hawflau @lucashuy