Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ruby3.2 support (#450) (#470) #5186

Merged
merged 3 commits into from
May 26, 2023
Merged

feat: add ruby3.2 support (#450) (#470) #5186

merged 3 commits into from
May 26, 2023

Conversation

mndeveci
Copy link
Contributor

Add ruby3.2 runtime support.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@moelasmar @trivenay
@mndeveci @briensea
feat: add ruby3.2 support (aws#450) (aws#470)
9e2cda2 
* Onboarded ruby3.2

* Re-order runtimes in test_cli.

* Remove deprecated Python3.6

* Add ruby3.2 to build.yml.

* Update build.yml

* Update build.yml to run Ruby3.2.

* temp: use private lambda builders

* temp: use private lambda builders

* try

* try use GH_TOKEN to access private repo

* try use GH_TOKEN to access private repo

* try use GH_TOKEN to access private repo

* Revert "try use GH_TOKEN to access private repo"

This reverts commit eadf4ea650985a4b4fabe5ff82b73eac01dc7c32.

* Revert "try use GH_TOKEN to access private repo"

This reverts commit a32b86c51ce162ca0680b303dcd889bd65385214.

* Revert "try use GH_TOKEN to access private repo"

This reverts commit 52ff9084d0c723ce3970ec60ad233343c3fe3157.

* Revert "try"

This reverts commit 5fc353914e2c126b4a04e2a3b6040356a91787dc.

* Revert "temp: use private lambda builders"

This reverts commit e39d06f6dc5e0a4ffeee1a2357eafd9b2672d118.

---------

Co-authored-by: trivenay <[email protected]>
Co-authored-by: Mehmet Nuri Deveci <[email protected]>
Co-authored-by: Sean O Brien <[email protected]>
@mndeveci mndeveci requested a review from a team as a code owner May 19, 2023 00:04
@mndeveci mndeveci requested review from lucashuy and moelasmar May 19, 2023 00:04
@github-actions github-actions bot added pr/internal area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke labels May 19, 2023
@moelasmar moelasmar enabled auto-merge May 26, 2023 06:07
@moelasmar moelasmar added this pull request to the merge queue May 26, 2023
Merged via the queue into aws:develop with commit de9da32 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moelasmar moelasmar moelasmar approved these changes

@hawflau hawflau hawflau approved these changes

@lucashuy lucashuy Awaiting requested review from lucashuy lucashuy was automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mndeveci @hawflau @moelasmar