fix: Relaxed OpenApi authorizer definition #5182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moelasmar
reviewed
May 19, 2023
| @@ -152,9 +152,9 @@ def get_authorizers(self, event_type: str = Route.API) -> Dict[str, Authorizer]: | |||
| auth_name, | |||
| ) | |||
|
|
|||
| if not identity_sources: | |||
| if not identity_sources and authorizer_type == LambdaAuthorizer.TOKEN: | |||
There was a problem hiding this comment.
can you add a comment to explain this condition
moelasmar
approved these changes
May 19, 2023
…li into relax_auth_validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N/A
Why is this change necessary?
Request based authorizers can have no identity sources defined if caching is disabled. We don't check for caching, but we can make the change to allow empty identity sources.
Additionally, the root level authorizer check was incorrectly written to not apply to Rest Apis, however this is not the case.
How does it address the issue?
Relaxes the check only for request based authorizers to allow empty identity sources. Also updates the validation to accept root default authorizers for Rest Apis when using the 3.x version specification.
What side effects does this change have?
None.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.