-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Link API Gateway Methods to Integrations #5174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Added one thing to be changed.
samcli/hook_packages/terraform/hooks/prepare/resources/apigw.py
Outdated
Show resolved
Hide resolved
moelasmar
reviewed
May 16, 2023
samcli/hook_packages/terraform/hooks/prepare/resource_linking.py
Outdated
Show resolved
Hide resolved
moelasmar
reviewed
May 16, 2023
samcli/hook_packages/terraform/hooks/prepare/resources/apigw.py
Outdated
Show resolved
Hide resolved
moelasmar
reviewed
May 16, 2023
samcli/hook_packages/terraform/hooks/prepare/resources/apigw.py
Outdated
Show resolved
Hide resolved
moelasmar
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N/A
Why is this change necessary?
To support
sam local start-api
for Terraform resources, we need to read in the Terraform API Gateway resources and convert them to their corresponding CFN resources.How does it address the issue?
Adds support for linking API Gateway methods to their corresponding API Gateway integrations. Additional handling needed to be done for these resources since they don't map 1:1 between Terraform and CFN. In Terraform, integrations are their own resources whereas in CFN, they are a field under the
AWS::ApiGateway::Method
resource.RestApiId
andResourceId
fields, respectively.Uri
field of the integration.ApiGatewayMethod.Properties.Integration
field.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.