Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump boto3-stubs[apigateway,cloudformation,ecr,iam,lambda,s3,schemas,secretsmanager,signer,stepfunctions,sts,xray] from 1.21.21 to 1.26.131 in /requirements #5144

Merged
merged 7 commits into from
May 26, 2023
Merged

chore(deps-dev): bump boto3-stubs[apigateway,cloudformation,ecr,iam,lambda,s3,schemas,secretsmanager,signer,stepfunctions,sts,xray] from 1.21.21 to 1.26.131 in /requirements #5144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c8104ac
chore(deps-dev): bump boto3-stubs[apigateway,cloudformation,ecr,iam,l…
dependabot[bot] May 10, 2023
08ce8f7
Merge branch 'develop' into dependabot/pip/requirements/develop/boto3…
sriram-mv May 11, 2023
0125072
Merge branch 'develop' into dependabot/pip/requirements/develop/boto3…
jfuss May 22, 2023
3eff195
Merge branch 'develop' into dependabot/pip/requirements/develop/boto3…
moelasmar May 25, 2023
c87325a
Merge branch 'develop' into dependabot/pip/requirements/develop/boto3…
moelasmar May 26, 2023
439a60d
fix mypy issue
moelasmar May 26, 2023
4a5e8a3
Merge branch 'develop' into dependabot/pip/requirements/develop/boto3…
moelasmar May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pytest-cov==4.0.0
# mypy adds new rules in new minor versions, which could cause our PR check to fail
# here we fix its version and upgrade it manually in the future
mypy==0.790
boto3-stubs[apigateway,cloudformation,ecr,iam,lambda,s3,schemas,secretsmanager,signer,stepfunctions,sts,xray]==1.21.21
boto3-stubs[apigateway,cloudformation,ecr,iam,lambda,s3,schemas,secretsmanager,signer,stepfunctions,sts,xray]==1.26.131
types-pywin32==306.0.0.0
types-PyYAML==6.0.12
types-chevron==0.14.2.4
Expand Down
5 changes: 4 additions & 1 deletion samcli/lib/package/s3_uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import botocore
import botocore.exceptions
from boto3.s3 import transfer
from boto3.s3.transfer import ProgressCallbackInvoker

from samcli.commands.package.exceptions import BucketNotSpecifiedError, NoSuchBucketError
from samcli.lib.package.local_files_utils import get_uploaded_s3_object_name
Expand Down Expand Up @@ -103,7 +104,9 @@ def upload(self, file_name: str, remote_path: str) -> str:
raise BucketNotSpecifiedError()

if not self.no_progressbar:
print_progress_callback = ProgressPercentage(file_name, remote_path)
print_progress_callback = ProgressCallbackInvoker(
ProgressPercentage(file_name, remote_path).on_progress
)
future = self.transfer_manager.upload(
file_name, self.bucket_name, remote_path, additional_args, [print_progress_callback]
)
Expand Down