Unexisting repository for hello-nodejs template

[alexcasalboni]

Description:

The repository referenced here doesn't seem to exist (https://github.com/aws-samples/cookiecutter-aws-sam-hello-nodej).

@heitorlessa @sanathkr is it just a broken link or maybe the repo is private?

I noticed because I wanted to improve that template, although now I'm realizing that all the templates are in this repository as well, so I can just update the nodejs template here.

But still :)

Observed result: The package.json file is referencing an unexisting repo.

Expected result: The repo should exist / be public.

[jfuss]

@alexcasalboni I think we should just remove it (or update it to point to the cli) since that is the example and is within the cli already.

[alexcasalboni]

That makes sense to me.

[jfuss]

Do you have a preference on which is best (remove or update)? I am inclined to just remove but I am not a node dev so it may make more sense to update it to the cli.

[alexcasalboni]

As documented here, the repository field is meant to instruct a computer (i.e. not a human) on "where your code lives".

Imho, we could just link the SAM CLI repo for all the templates, and then instruct users to customize it once they set up their own repo.

[DebbieIsMyName]

Updated with unbroken link.

[heitorlessa]

Hey Alex, just seeing this now. Initial idea was to create a repo for each runtime and move them to foster enhancements and add integration tests for them alone and make the Sam cli lean. While this is not complete I’d vote to remove the link altogether to not mislead anyone who may want to look up that README

…

On Fri, 3 Aug 2018 at 23:57, DebbieIsMyName ***@***.***> wrote: Updated with unbroken link. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#585 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADL4BBLPvY7yHRyyjP1WFKfazgTy2ZOJks5uNNVOgaJpZM4Vk37r> .

[jfuss]

@heitorlessa We already merged the PR that points the package.json to the cli repo. I think having this point to the cli for now is fine since that is where it lives. If we later move these out, we can update it further then.

[alexcasalboni]

Sounds good to me :)

[heitorlessa]

Agreed ;)

…

On Tue, 7 Aug 2018 at 22:37, Alex Casalboni ***@***.***> wrote: Closed #585 <#585>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#585 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADL4BLH1HM8iBzz3Jirhi8LUDOFRxfqmks5uOgiwgaJpZM4Vk37r> .