Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AWS::LanguageExtensions #307

Closed
wants to merge 4 commits into from
Closed

feat: add AWS::LanguageExtensions #307

wants to merge 4 commits into from

Conversation

hoffa
Copy link

@hoffa hoffa commented Nov 14, 2022

Issue #, if available:

Description of changes:

Adds AWS::LanguageExtensions by default, which resolves intrinsic functions known before deployment (see aws/serverless-application-model#2533).

Specifying it before the SAM transform, as described in this blog post.

Generated with:

grep -Frl -- '- AWS::Serverless-2016-10-31' | while IFS= read -r f; do sed -i.bak 's/- AWS::Serverless-2016-10-31/- AWS::LanguageExtensions\n- AWS::Serverless-2016-10-31/g' "$f"; done
grep -Frl 'Transform: AWS::Serverless-2016-10-31' | while IFS= read -r f; do sed -i.bak 's/Transform: AWS::Serverless-2016-10-31/Transform:\n- AWS::LanguageExtensions\n- AWS::Serverless-2016-10-31/g' "$f"; done
git clean -f

Tested with:

sam init --location aws-sam-cli-app-templates/python3.9/cookiecutter-aws-sam-hello-python

And deploying it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hoffa hoffa changed the title Add LanguageExtensions Add AWS::LanguageExtensions Nov 14, 2022
@hoffa hoffa changed the title Add AWS::LanguageExtensions Add AWS::LanguageExtensions Nov 14, 2022
@hoffa hoffa changed the title Add AWS::LanguageExtensions feat: add AWS::LanguageExtensions Nov 14, 2022
@hoffa hoffa marked this pull request as ready for review November 16, 2022 21:08
@hoffa hoffa requested a review from a team as a code owner November 16, 2022 21:08
@hoffa hoffa requested review from mndeveci and qingchm and removed request for a team November 16, 2022 21:08
@aahung
Copy link
Contributor

aahung commented Nov 16, 2022

Is it possible to write a script to verify all generated template can pass sam validate?

@hoffa hoffa marked this pull request as draft November 16, 2022 22:05
@hoffa
Copy link
Author

hoffa commented Nov 30, 2022

Closing for now; SAM CLI doesn't support AWS::LanguageExtensions.

@hoffa hoffa closed this Nov 30, 2022
@hoffa
Copy link
Author

hoffa commented Jan 14, 2023

For posterity, some examples of weird behavior when together: aws-cloudformation/cfn-lint#1657 (comment) and aws/serverless-application-model#2778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants