Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ruby2.7 support #128

Merged
merged 3 commits into from
Feb 8, 2024
Merged

chore: Remove ruby2.7 support #128

merged 3 commits into from
Feb 8, 2024

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Feb 7, 2024

Description of changes:

Removes Dockerfile for ruby2.7 build image and its related configuration and tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hnnasit hnnasit requested a review from a team as a code owner February 7, 2024 16:39
@hnnasit hnnasit requested review from bentvelj and mildaniel February 7, 2024 16:39
Copy link

@jysheng123 jysheng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucashuy
Copy link
Contributor

lucashuy commented Feb 7, 2024

Could we remove the pytest marker for ruby2.7:

I don't think Github lets me leave a suggestion on an unchanged file, so posting here instead.

@hnnasit
Copy link
Contributor Author

hnnasit commented Feb 7, 2024

Could we remove the pytest marker for ruby2.7:


I don't think Github lets me leave a suggestion on an unchanged file, so posting here instead.

Thanks! Good catch.

@hnnasit hnnasit merged commit a3eac3c into aws:develop Feb 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants