Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch lambda layers to use a region allow list for publishing #1422

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: Switch lambda layers to use a region allow list for publishing #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lambda-layers/bin/publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ getRegions().then(regions => {
region,
runtimes,
).catch(e => {
console.error(`Failed publishing in ${region}, which may be due to the REGION_DENY_LIST needing updating. Error: ${e}`);
console.error(`Failed publishing in ${region}, which may be due to the REGION_ALLOW_LIST needing updating. Error: ${e}`);
throw e;
});
}
Expand Down
36 changes: 20 additions & 16 deletions lambda-layers/lib/get-regions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,31 @@ import {
GetParametersByPathCommand,
} from '@aws-sdk/client-ssm';

// These regions need to be enabled for the AWS account being used for publishing, so we skip them
// Regions introduced before March 20, 2019 are enabled by default, so we maintain this
// allowlist to only publish to these regions since we can gurantee the account uses them.
// See https://docs.aws.amazon.com/accounts/latest/reference/manage-acct-regions.html
const REGION_DENY_LIST = [
'af-south-1',
'ap-east-1',
'ap-south-2',
'ap-southeast-3',
'ap-southeast-4',
'ap-southeast-5',
'ca-west-1',
'eu-south-1',
'eu-south-2',
'eu-central-2',
'il-central-1',
'me-south-1',
'me-central-1',
const REGION_ALLOW_LIST = [
'ap-northeast-1',
'ap-northeast-2',
'ap-northeast-3',
'ap-southeast-1',
'ap-southeast-2',
'ca-central-1',
'eu-central-1',
'eu-north-1',
'eu-west-1',
'eu-west-2',
'eu-west-3',
'sa-east-1',
'us-east-1',
'us-east-2',
'us-west-1',
'us-west-2'
];

function isValidRegion(region: string): boolean {
return (
!REGION_DENY_LIST.includes(region)
REGION_ALLOW_LIST.includes(region)
&& !region.startsWith('cn-')
&& !region.startsWith('us-gov-')
);
Expand Down
Loading
Loading