chore(deps): deprecate NodeJS pre 18.* (#1163)

aws · Dec 19, 2023 · 84955d1 · 84955d1
1 parent f5edaeb
commit 84955d1
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@ It offers high-level object-oriented abstractions to define render farm infrastr
 using the power of Python and Typescript.
 
 The RFDK is available in:
-- Javascript, Typescript ([Node.js >= 18.0.0](https://nodejs.org/download/release/latest-v18.x/))
+- Javascript, Typescript ([Node.js >= 18.0.0](https://nodejs.org/download/release/latest-v18.x/) officially supported, [Node.js >= 14.15.0](https://nodejs.org/download/release/latest-v14.x/) unofficially supported)
   - We recommend using an [Active LTS Release](https://nodejs.org/en/about/releases/)
 - Python ([Python >= 3.6](https://www.python.org/downloads/))
 

diff --git a/integ/package.json b/integ/package.json
@@ -85,6 +85,6 @@
     "constructs": "^10.0.0"
   },
   "engines": {
-    "node": ">= 18.0.0"
+    "node": ">= 14.15.0"
   }
 }
diff --git a/lambda-layers/package.json b/lambda-layers/package.json
@@ -24,7 +24,7 @@
     "watch": "tsc -w"
   },
   "engines": {
-    "node": ">= 18.0.0"
+    "node": ">= 14.15.0"
   },
   "stability": "stable",
   "maturity": "stable",

diff --git a/packages/aws-rfdk/docs/upgrade/upgrading-1.3.md b/packages/aws-rfdk/docs/upgrade/upgrading-1.3.md
@@ -2,7 +2,7 @@
 
 ## Updating Node.js
 
-Node 14 is End of Life and RFDK >= 1.3.x no longer supports it. Node.js 18.0.0 is the minimum version
-that RFDK now supports.
+Node 14 is End of Life and RFDK >= 1.3.x no longer officially supports it. Node.js 18.0.0 is now
+the minimum officially supported version that RFDK now supports.
 
 You can follow our [installation guide](CONTRIBUTING.md#installing-nodejs) for Node.js to upgrade to the latest version.
diff --git a/packages/aws-rfdk/lib/index.ts b/packages/aws-rfdk/lib/index.ts
@@ -5,3 +5,9 @@
 
 export * from './core';
 export * as deadline from './deadline';
+
+// Emit a warning for NodeJS versions earlier than 18.x
+const version = process.versions.node.split('.').map(parseInt);
+if (version[0] < 18) {
+  process.emitWarning(`RFDK officially supports NodeJS 18 or greater, but got ${process.versions.node}`);
+}
diff --git a/packages/aws-rfdk/package.json b/packages/aws-rfdk/package.json
@@ -100,7 +100,7 @@
     "constructs": "^10.0.0"
   },
   "engines": {
-    "node": ">= 18.0.0"
+    "node": ">= 14.15.0"
   },
   "stability": "stable",
   "maturity": "stable"

diff --git a/tools/pkglint/lib/rules.ts b/tools/pkglint/lib/rules.ts
@@ -428,7 +428,7 @@ export class MustHaveNodeEnginesDeclaration extends ValidationRule {
   public readonly name = 'package-info/engines';
 
   public validate(pkg: PackageJson): void {
-    expectJSON(this.name, pkg, 'engines.node', '>= 18.0.0');
+    expectJSON(this.name, pkg, 'engines.node', '>= 14.15.0');
   }
 }