Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove creation of SSH keys of type DSA to prevent cluster creation failure when the OS ships a version of OpenSSH that does not support DSA keys. #2873

Merged

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Feb 5, 2025

Description of changes

Remove creation of SSH keys of type DSA to prevent cluster creation failure when the OS ships a version of OpenSSH that does not support DSA keys.

Tests

Cluster creation with login nodes succeeded.
Can SSH into the login nodes and submit jobs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ailure

when the OS ships a version of OpenSSH that does not support DSA keys.
@gmarciani gmarciani force-pushed the wip/mgiacomo/3.12.0/login-node-ubu-dsa-1 branch from 8fd8b7a to 425e37f Compare February 5, 2025 22:07
@acurley
Copy link

acurley commented Feb 7, 2025

My team eagerly awaits the merging of this PR. It is a production blocker for us.

@gmarciani gmarciani marked this pull request as ready for review February 7, 2025 19:15
@gmarciani gmarciani requested review from a team as code owners February 7, 2025 19:15
@gmarciani gmarciani enabled auto-merge (rebase) February 7, 2025 19:16
@gmarciani gmarciani merged commit 1a93e9d into aws:develop Feb 7, 2025
32 of 34 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/3.12.0/login-node-ubu-dsa-1 branch February 7, 2025 19:33
@acurley
Copy link

acurley commented Feb 7, 2025

Thanks @gmarciani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants