Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicas #875

Merged
merged 8 commits into from
Aug 17, 2023
Merged

Replicas #875

merged 8 commits into from
Aug 17, 2023

Conversation

GavinBurris42
Copy link
Contributor

Issue #, if available:
#775

Description of changes:
Added Replica Usage section to the main README.md under "AWS Node Termination Handler - Queue Processor". This provides information on the usage of single and multiple replicas in their handling of messages with SQS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinBurris42 GavinBurris42 requested a review from a team as a code owner August 9, 2023 22:28
pkg/node/node.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section title of "Replica Usage" implies

  1. The section should show how to enable multiple replicas
    • What are the relevant Helm chart values?
  2. Reasons for and against using multiple replicas; maybe with scenario recommendations

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@GavinBurris42 GavinBurris42 requested a review from cjerad August 11, 2023 20:41
Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LikithaVemulapalli LikithaVemulapalli merged commit d5c7ede into aws:main Aug 17, 2023
@GavinBurris42 GavinBurris42 deleted the replicas branch August 17, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants