-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topologySpreadConstraints to Deployment #859
Conversation
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sgametrio! Thanks for the PR. Please add the new value to the list in config/helm/aws-node-termination-handler/README.md
.
Hi @cjerad Thanks for the comment. I updated the file as you suggested. Please feel free to suggest any re-wording or further changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description of changes: When using a single replica, it can happen that the Node on which the
aws-node-termination-handler
Pod is running gets terminated. If this happens then, the Pod can't listen for the event and detect it to handle it gracefully.Running a HA
aws-node-termination-handler
helps in dealing with this by reducing probability that all the replicas gets terminated at the same time, but doesn't guarantee that the replicas are scheduled on different nodes.By introducing
.Values.topologySpreadConstraints
field we allow optional forcing of scheduling pods on different nodes, therefore reducing to ~0 the possibility that no Pods are available to listen for events.Example of using topologySpreadConstraints
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.