Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS Health Event Bridge Rule #633

Merged
merged 2 commits into from
Apr 28, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix AWS Health Event Bridge Rule
LikithaVemulapalli committed Apr 27, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit dd12098589133801dea4bee307d6591db74dd5b0
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -329,7 +329,7 @@ $ aws events put-targets --rule MyK8sInstanceStateChangeRule \
$ aws events put-rule \
--name MyK8sScheduledChangeRule \
--event-pattern "{\"source\": [\"aws.health\"],\"detail-type\": [\"AWS Health Event\"]}"
--event-pattern "{\"source\": [\"aws.health\"],\"detail-type\": [\"AWS Health Event\"],\"detail\": {\"service\": [\"EC2\"],\"eventTypeCategory\": [\"scheduledChange\"]}}"
$ aws events put-targets --rule MyK8sScheduledChangeRule \
--targets "Id"="1","Arn"="arn:aws:sqs:us-east-1:123456789012:MyK8sTermQueue"
8 changes: 4 additions & 4 deletions pkg/monitor/sqsevent/scheduled-change-event.go
Original file line number Diff line number Diff line change
@@ -76,13 +76,13 @@ func (m SQSMonitor) scheduledEventToInterruptionEvents(event *EventBridgeEvent,
}

if scheduledChangeEventDetail.Service != "EC2" {
err := fmt.Errorf("events from Amazon EventBridge for service (%s) are not supported", scheduledChangeEventDetail.Service)
return append(interruptionEventWrappers, InterruptionEventWrapper{nil, err})
AustinSiu marked this conversation as resolved.
Show resolved Hide resolved
log.Warn().Msgf("events from Amazon EventBridge for service (%s) are not supported", scheduledChangeEventDetail.Service)
return append(interruptionEventWrappers, InterruptionEventWrapper{nil, nil})
}

if scheduledChangeEventDetail.EventTypeCategory != "scheduledChange" {
err := fmt.Errorf("events from Amazon EventBridge with EventTypeCategory (%s) are not supported", scheduledChangeEventDetail.EventTypeCategory)
return append(interruptionEventWrappers, InterruptionEventWrapper{nil, err})
AustinSiu marked this conversation as resolved.
Show resolved Hide resolved
log.Warn().Msgf("events from Amazon EventBridge with EventTypeCategory (%s) are not supported", scheduledChangeEventDetail.EventTypeCategory)
return append(interruptionEventWrappers, InterruptionEventWrapper{nil, nil})
}

for _, affectedEntity := range scheduledChangeEventDetail.AffectedEntities {