Fix custom nodeAffinity via values.yaml

[ngoyal16]

Issue #495

Description of changes:

1. Removed arch affinity from nodeAffinity completely
2. Removed OS node selector from nodeAffinity. As it already exists in nodeSelector

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[bwagner5]

We need to include the OS in the node selector for the daemonset definitions.

The Fargate node affinity can be moved into the values.yaml.

Thanks for taking on this task! :)

[ngoyal16]

We need to include the OS in the node selector for the daemonset definitions.

Already there

The Fargate node affinity can be moved into the values.yaml.

can't we add following key pair in node selector for deamonset

eks.amazonaws.com/compute-type : ec2

As we need it on EC2 servers only

[bwagner5]

We need to include the OS in the node selector for the daemonset definitions.

Already there

The Fargate node affinity can be moved into the values.yaml.

can't we add following key pair in node selector for deamonset

eks.amazonaws.com/compute-type : ec2

As we need it on EC2 servers only

Ah sorry, I did not see the OS and Arch in the node selector, but I see it now :)

The potential problem with doing an eks.amazonaws.com/compute-type node selector is when operating in an environment that does not set that label. I don't think Kops will set that label.

[ngoyal16]

@bwagner5 as per the issue, peoples are facing issue with deployment type only not with the dameonsets one. so i guess we can go with this fix.

[bwagner5]

@ngoyal16 can you move the fargate anti-affinity to the values.yaml file?

[ngoyal16]

\rerun

[snay2]

LGTM. Thanks!

[bwagner5]

/lgtm