Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECR login and add install-awscli script #332

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Dec 23, 2020

Issue #, if available:
N/A

Description of changes:
v1.11.2's release has been stuck because of issues with the ECR login for Windows and an old version of the aws-cli installed on github actions runners.

This PR adds:

  • scripts/install-awscli which installs the specified AWS CLI version on mac, windows, or linux
  • Fixes ecr-login script to work across linux, windows, and mac
  • Fixes retag script to work on windows
  • Fix shellcheck test to exclude the build dir

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@imuqtadir imuqtadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit 1319288 into aws:main Dec 23, 2020
haugenj pushed a commit to haugenj/aws-node-termination-handler that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants