-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Windows node support #185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 81.30% 81.24% -0.07%
==========================================
Files 8 10 +2
Lines 765 773 +8
==========================================
+ Hits 622 628 +6
- Misses 128 129 +1
- Partials 15 16 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of comments on the run unit tests thru docker script to simplify.
project_root_dir="$(cd "$(dirname "$0")/.." && pwd -P)" | ||
work_dir="/workplace/aws-node-termination-handler" | ||
container_name="nth_unit_test_on_linux" | ||
deps="go,git,make" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using alpine and installing dependencies, you can use the golang:1 docker container which already has go, git, and make installed.
IFS=',' read -ra deps <<< "$deps" | ||
echo "dependencies to install: ${deps[@]}" | ||
|
||
docker container create \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default workflow would be to run the unit tests and discard the container. Maybe change "recreate" to "preserve" instead which would effectively remove the --rm
from the command below.
docker run -it --rm -e GOPROXY=direct --volume "$project_root_dir:$work_dir" --workdir "$work_dir" --name "$container_name" golang:1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks very good! Going to go ahead and merge. We'll do some cleanup and polishing in smaller PRs.
I'm getting the following error since upgrading from 0.8.0 to 0.9.2. Seems potentially related to this PR. I have not set that value.
|
Issue #, if available:
Resolves #8
Description of changes:
Adds support for running on Windows nodes. Also updates build and test scripts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.