Fix ASGLifecycle showing up as UnknownInterruption on K8 events (#1024) #1096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1024
Description of changes:
getReasonForKindV1 used for K8sEventsRecorder was not catching
ASGLifeCycle
andStateChange
events, making the event fall to the default case ofunknownInterruption
. Added new case loops that catchASGLifeCycle
andStateChange
event.Testing methodology
Reproduced the issue #1024 via Queue processor mode. First, created EKS Cluster associated with Auto Scaling Group (ASG). Manually edited and decreased the capacity of ASG to shut down EC2 instances and trigger
ASGLifeCycle
andStateChange
events.Made code fixes and tested the change by building a docker image and deploying that NTH version via AWS Elastic Container Registry (ECR) with helm. Test output can be seen below.
Test Output
Reproducing the issue for
ASGLifeCycle
appearing asunknownInterruption
Reproducing the issue for
StateChange
appearing asunknownInterruption
Fixing the issue for
ASGLifeCycle
appearing asunknownInterruption
Fixing the issue for
StateChange
appearing asunknownInterruption
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.