Fix prometheus port (#1078) and add unit test for opentelemetry (#1088) #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for opentelemetry (aws#1088)
Lu-David
previously approved these changes
Dec 5, 2024
| conn, err = net.DialTimeout("tcp", fmt.Sprintf("localhost:%d", mockClosedPort), time.Second) | ||
| if err == nil { | ||
| conn.Close() | ||
| t.Errorf("server should not listening on port %d: %v", mockClosedPort, err) |
| metrics.NodeActionsInc(mockAction, mockNodeName2, mockEventID2, nil) | ||
| metrics.NodeActionsInc(mockAction, mockNodeName3, mockEventID3, errors.New("mockError")) | ||
|
|
||
| rr := mockMetricsRequest() |
There was a problem hiding this comment.
What does rr mean? Could we rename to something more specific?
There was a problem hiding this comment.
I assume request response?
There was a problem hiding this comment.
Fixed by renaming to responseRecorder.
|
|
||
| metrics := getMetrics(t) | ||
|
|
||
| errorEventLables := []attribute.KeyValue{labelEventErrorWhereKey.String(mockErrorEvent)} |
There was a problem hiding this comment.
Typo: errorEventLabels. Same for other areas
| h.Equals(t, http.StatusOK, status) | ||
| } | ||
|
|
||
| func getMetricsMap(body string) map[string]string { |
There was a problem hiding this comment.
Could you add a comment here indicating an example of what the body might look like? Is there only a specific format it accepts? Just so it's easier to understand what this does?
There was a problem hiding this comment.
Fixed by adding doc comment for example response body.
Lu-David
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix prometheus port (#1078) and add unit test for opentelemetry (#1088)
**Issue #, if available:
#1078
#1088
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.