Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imds asg lifecycle support #1067

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Imds asg lifecycle support #1067

merged 10 commits into from
Sep 12, 2024

Conversation

Lu-David
Copy link
Contributor

@Lu-David Lu-David commented Sep 10, 2024 •
edited
Loading

Issue #837

Description of changes:

  1. Functionality for asg lifecycle in imds mode
  2. unit tests for asg lifecycle
  3. end-to-end tests for asg lifecycle

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Lu-David Lu-David changed the title Imds asg lifecycle Imds asg lifecycle support Sep 10, 2024
@Lu-David Lu-David marked this pull request as ready for review September 10, 2024 21:30
@Lu-David Lu-David requested a review from a team as a code owner September 10, 2024 21:30
LikithaVemulapalli
LikithaVemulapalli approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on e2e test script! LGTM

@Lu-David Lu-David merged commit 83a836d into aws:main Sep 12, 2024
16 checks passed
@LikithaVemulapalli LikithaVemulapalli mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LikithaVemulapalli LikithaVemulapalli LikithaVemulapalli approved these changes

@steveshidev steveshidev Awaiting requested review from steveshidev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lu-David @LikithaVemulapalli @pete911